Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMMON: introduce substr for U32String #2585

Merged
merged 1 commit into from Nov 1, 2020
Merged

COMMON: introduce substr for U32String #2585

merged 1 commit into from Nov 1, 2020

Conversation

@phcoder
Copy link
Contributor

@phcoder phcoder commented Oct 31, 2020

It's safer than direct array manipulation. Replace current uses
of subsetting with substr.

It's safer than direct array manipulation. Replace current uses
of subsetting with substr.
@bluegr
Copy link
Member

@bluegr bluegr commented Nov 1, 2020

Quite clean and straightforward. Thumbs up from me! :)

@phcoder phcoder merged commit 3fc822e into scummvm:master Nov 1, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deepcode-ci-bot Well done, no issues found!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.