Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
GUI: Add a tab for backend-specific options #2591
It's an interesting change. Is this done to provide better isolation for such features ? (These features already appeared in a "Control" tab separately, but the code behind that was not a clear that those were backend specific?)
My main concern is whether a regression would be introduced by the example case for Android -- since in a previous fix (e25ac0b#diff-d112ba6d5371b6b878f86ddd82035bd646f53e85e0a2cc5164233b36f009c11d) I thought it would be better to explicitly set values for un-configured settings so that they would have actually their "keys" registered with ConfMan and hasKey() (if used by any external method, before retrieving the key value) would return "true" properly.
Yes, that was part of the reason for doing this. The other part was to allow the custom dialogs in some of the other ports to be replaced with something that's integrated into the main GUI.
That shouldn't be an issue in this case, since