Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWITCH: Implement OSystem_Switch::getSystemLanguage() #2597

Merged
merged 1 commit into from Nov 7, 2020

Conversation

@usineur
Copy link
Contributor

@usineur usineur commented Nov 4, 2020

This commit adds language detection on Switch

@usineur
Copy link
Contributor Author

@usineur usineur commented Nov 6, 2020

@rsn8887 can you review this pls ?

@rsn8887
Copy link
Contributor

@rsn8887 rsn8887 commented Nov 7, 2020

Looks good to me.

@rsn8887 rsn8887 merged commit 5a31319 into scummvm:master Nov 7, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deepcode-ci-bot Well done, no issues found!
Details
@rsn8887
Copy link
Contributor

@rsn8887 rsn8887 commented Nov 7, 2020

Merged, thank you!

@usineur usineur deleted the usineur:switch_language branch Nov 7, 2020
case SetLanguage_JA: return "ja_JP";
case SetLanguage_ENUS: return "en_US";
case SetLanguage_FR: return "fr_FR";
case SetLanguage_FRCA: return "fr_FR";

This comment has been minimized.

@phcoder

phcoder Nov 7, 2020
Contributor

Why fr_FR and not fr_CA?

This comment has been minimized.

@usineur

usineur Nov 7, 2020
Author Contributor

fr_CA doesn't exist in LanguageDescription.

case SetLanguage_NL: return "nl_NL";
case SetLanguage_PT: return "pt_PT";
case SetLanguage_RU: return "ru_RU";
case SetLanguage_ZHTW: return "zh_HK";

This comment has been minimized.

@phcoder

phcoder Nov 7, 2020
Contributor

Why not zh_TW?

This comment has been minimized.

@usineur

usineur Nov 7, 2020
Author Contributor

yes, my mistake.

@rsn8887 can you fix that ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.