Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMMON: Add conversion operator from UnicodeBiDiText to U32String #2599

wants to merge 1 commit into from


Copy link

@criezy criezy commented Nov 4, 2020

Replace the U32String constructor that takes a UnicodeBiDiText by an implicit conversion operator in UnicodeBiDiText. This serves the same purpose of allowing to use a UnicodeBiDiText in places where a U32String is expected (such as in ThemeEngine::drawDDText() , but avoids making a copy (although we can still make a copy using the U32String copy constructor if that is what we want to do).

I am suggesting this change in a pull request in case C++ experts want to have a look and comment before this is merged, as I may have missed something.

This replaces the U32String constructor that takes a UnicodeBiDiText
and serves the same purpose, but avoids making a copy.
Copy link
Member Author

@criezy criezy commented Nov 7, 2020

I merged the change manually after resolving the conflict.

@criezy criezy closed this Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.