Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
SCI: Add support for Korean fan translation #2604
This PR is part of scummvm-kor merge project.
The patch adds ability to load external Korean text resource file similar to Japanese version, and to display korean text with 2x multiplied resolution (also similar to Japanese version).
This looks great and is very exciting! I had no idea there were so many Korean SCI translations.
Since GK1 Korean is high-res only, GAMEOPTION_HIGH_RESOLUTION_GRAPHICS should be removed from its DOS detection table entry, as it is for Windows CD and Mac. That prevents giving users an option that doesn't do anything and it means you don't need the GK1 exception you've added to GfxFrameout::detectHiRes(). High-res is the default with that option removed. The existing exceptions in that function are for known low-res versions.
I'd like to see the repeated message-map tests in resource.cpp moved into a function like isKoreanMessageMap() with a comment explaining why that needs to be handled differently. I spend a lot of time in resource.cpp, and as I'm sure you've noticed, it's understandably built up a lot of cryptic exceptions. =)