Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCUMM: Add support for basic Korean fan translation #2605

Merged
merged 1 commit into from Nov 6, 2020

Conversation

@wonst719
Copy link
Contributor

@wonst719 wonst719 commented Nov 6, 2020

SCUMM: Add support for basic Korean fan translation

This PR is part of scummvm-kor merge project.

It makes minimal changes enabling Korean fan translation for SCUMM games.
Most of the foundation is already laid, so just removing restriction is enough for basic functions.
However, many games require some more changes to actually "work", so those will come as separate PR.

Tested with:

  • Loom (DOS/CD/Korean patched)
  • Monkey Island 2 (DOS/Korean patched)
  • Monkey Island 2 (FMT/Japanese)
  • DOTT (DOS/CD/Korean patched)

scummvm-loom-vga-kr-00001

@sev-

This comment has been minimized.

Copy link

@sev- sev- commented on engines/scumm/string.cpp in 73bca81 Nov 3, 2020

Are you sure this doesn't break Japanese?

This comment has been minimized.

Copy link
Owner Author

@wonst719 wonst719 replied Nov 3, 2020

Yep, it's essentially the same code if _language is set to JA_JPN.

@athrxx
Copy link
Member

@athrxx athrxx commented Nov 6, 2020

This one looks fine to me 👍

@sev-
Copy link
Member

@sev- sev- commented Nov 6, 2020

Thanks, merging.

@sev- sev- merged commit 9a54c22 into scummvm:master Nov 6, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deepcode-ci-bot Well done, no issues found!
Details
@wonst719 wonst719 deleted the wonst719:scummvm-kor-feature-scumm branch Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.