Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCUMM: Support variation of Korean postpositions #2607

Merged

Conversation

@wonst719
Copy link
Contributor

@wonst719 wonst719 commented Nov 6, 2020

This PR is part of scummvm-kor merge project.

Korean text postpositions varies with the final consonant of the previous character.
e.g.
Book = 책
Ladder = 사다리
Use book = 책'을' 사용하기
Use ladder = 사다리'를' 사용하기

This patch introduces special "verb parser" to support this variation.
Only used in Monkey1 and Monkey2.

scummvm-monkey2-kr-00006

scummvm-monkey2-kr-00007

(망치'를' 향해 걸어가기 vs 달력'을' 향해 걸어가기)

@sev-

This comment has been minimized.

Copy link

@sev- sev- commented on engines/scumm/string.cpp in 73bca81 Nov 3, 2020

Are you sure this doesn't break Japanese?

This comment has been minimized.

Copy link
Owner Author

@wonst719 wonst719 replied Nov 3, 2020

Yep, it's essentially the same code if _language is set to JA_JPN.

@sev-

This comment has been minimized.

Copy link

@sev- sev- commented on engines/scumm/ks_check.cpp in 0a98a89 Nov 3, 2020

Code formatting is wrong

@sev-

This comment has been minimized.

Copy link

@sev- sev- commented on engines/scumm/ks_check.cpp in 0a98a89 Nov 3, 2020

Please add a comment here explaining briefly the purpose of this table (at least mention that it is Korean-related)

@athrxx
Copy link
Member

@athrxx athrxx commented Nov 6, 2020

And this one doesn't seem to be guarded against our existing code, e. g. you just check _language == Common::KO_KOR instead of using the new isScummvmKorTarget() method.
So, is there any way this could affect DIG or COMI? Or is it only used in code parts that these games will never reach (e. g. verb interface)?

We just recently had some fixes to make DIG and COMI games almost pixel-exact. That's why I am asking...

@sev-
Copy link
Member

@sev- sev- commented Nov 6, 2020

Thank you!

@sev- sev- merged commit fe756f6 into scummvm:master Nov 6, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deepcode-ci-bot Well done, no issues found!
Details
@wonst719 wonst719 deleted the wonst719:scummvm-kor-feature-scumm-postposition branch Nov 7, 2020
@wonst719
Copy link
Contributor Author

@wonst719 wonst719 commented Nov 7, 2020

Thanks.

And this one doesn't seem to be guarded against our existing code, e. g. you just check _language == Common::KO_KOR instead of using the new isScummvmKorTarget() method.
So, is there any way this could affect DIG or COMI? Or is it only used in code parts that these games will never reach (e. g. verb interface)?

We just recently had some fixes to make DIG and COMI games almost pixel-exact. That's why I am asking...

I don't think this will affect DIG or COMI. It's only used in verb interface for MI1 and MI2. You're right that it should be guarded against existing code though. I will add the check soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.