Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
SCUMM: Support variation of Korean postpositions #2607
This PR is part of scummvm-kor merge project.
Korean text postpositions varies with the final consonant of the previous character.
This patch introduces special "verb parser" to support this variation.
(망치'를' 향해 걸어가기 vs 달력'을' 향해 걸어가기)
And this one doesn't seem to be guarded against our existing code, e. g. you just check _language == Common::KO_KOR instead of using the new isScummvmKorTarget() method.
We just recently had some fixes to make DIG and COMI games almost pixel-exact. That's why I am asking...
I don't think this will affect DIG or COMI. It's only used in verb interface for MI1 and MI2. You're right that it should be guarded against existing code though. I will add the check soon.