Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCUMM: Hacks for alternative line-break #2608

Merged
merged 3 commits into from Nov 6, 2020

Conversation

@wonst719
Copy link
Contributor

@wonst719 wonst719 commented Nov 6, 2020

This PR is part of scummvm-kor merge project.

This patch introduces alternative line-break style (similar to CSS word-break: break-all), and moves the hanging punctuation mark to the next line for cleaner text display.
This is used in Monkey2 (in the Phatt Island Library.)

scummvm-monkey2-kr-00009

@sev-

This comment has been minimized.

Copy link

@sev- sev- commented on engines/scumm/string.cpp in 73bca81 Nov 3, 2020

Are you sure this doesn't break Japanese?

This comment has been minimized.

Copy link
Owner Author

@wonst719 wonst719 replied Nov 3, 2020

Yep, it's essentially the same code if _language is set to JA_JPN.

@sev-

This comment has been minimized.

Copy link

@sev- sev- commented on 5bbb6d3 Nov 3, 2020

Looks fine

@deepcode-ci-bot
Copy link

@deepcode-ci-bot deepcode-ci-bot bot commented Nov 6, 2020

Congratulations 🎉. DeepCode analyzed your code in 222.585 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

- use memcpy() instead of strcpy() to insert linebreak character
@wonst719 wonst719 force-pushed the wonst719:scummvm-kor-feature-scumm-linebreak branch from c58952b to f780b82 Nov 6, 2020
@athrxx
Copy link
Member

@athrxx athrxx commented Nov 6, 2020

It seems to be well guarded against the existing code. I don't exactly understand the purpose of the code (what is a 'hanging punctuation mark'?), but if this just about the layout of the Korean library index texts it shouldn't matter...

@sev-
Copy link
Member

@sev- sev- commented Nov 6, 2020

Thanks, merging.

@sev- sev- merged commit 1a0c320 into scummvm:master Nov 6, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deepcode-ci-bot Well done, no issues found!
Details
@wonst719 wonst719 deleted the wonst719:scummvm-kor-feature-scumm-linebreak branch Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.