Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KYRA: Fix crash in Siberian Goblin translation of HoF #2609

Merged
merged 2 commits into from Nov 6, 2020

Conversation

@phcoder
Copy link
Contributor

@phcoder phcoder commented Nov 6, 2020

No description provided.

@deepcode-ci-bot
Copy link

@deepcode-ci-bot deepcode-ci-bot bot commented Nov 6, 2020

DeepCode failed to analyze this pull request

Something went wrong despite trying multiple times, sorry about that.
Please comment this pull request with "Retry DeepCode" to manually retry, or contact us so that a human can look into the issue.

@phcoder phcoder force-pushed the phcoder:kyrafix2 branch from 2265c61 to 95a8d7d Nov 6, 2020
phcoder added 2 commits Nov 6, 2020
This fixes crash in Siberian Goblin translation of HoF on scarecrow scene
@phcoder phcoder force-pushed the phcoder:kyrafix2 branch from 95a8d7d to 50c8f1c Nov 6, 2020
@phcoder
Copy link
Contributor Author

@phcoder phcoder commented Nov 6, 2020

Retry DeepCode

@athrxx
Copy link
Member

@athrxx athrxx commented Nov 6, 2020

Thanks for your work 👍 . Merging.

@athrxx athrxx merged commit 7cda72a into scummvm:master Nov 6, 2020
1 of 2 checks passed
1 of 2 checks passed
deepcode-ci-bot DeepCode is checking for issues.
continuous-integration/travis-ci/pr The Travis CI build passed
Details
athrxx added a commit that referenced this pull request Nov 7, 2020
* KYRA: don't attempt to execute functions out of bounds

This fixes crash in Siberian Goblin translation of HoF on scarecrow scene

* KYRA: Add sanity check not to execut out of bounds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.