Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VITA: add support for booting game directly via bubble #2611

Closed
wants to merge 5 commits into from

Conversation

@cy33hc
Copy link

@cy33hc cy33hc commented Nov 7, 2020

Add support for booting a pre configured game directly via a custom bubble similar to RetroArch on the PSVita.

@deepcode-ci-bot
Copy link

@deepcode-ci-bot deepcode-ci-bot bot commented Nov 8, 2020

Congratulations 🎉. DeepCode analyzed your code in 0.73 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@rsn8887
Copy link
Contributor

@rsn8887 rsn8887 commented Nov 8, 2020

Thanks, but this is not acceptable in this form.

You can’t add executables to the code base, like you do in 82c4f74

Why not leave only the first commit? Don’t add that launcher stuff and executables and additional Makefile to ScummVM. It is not appropriate. Allow users to download it somewhere else from your webpage if they want.

@cy33hc
Copy link
Author

@cy33hc cy33hc commented Nov 9, 2020

@rsn8887 Reverted the changes for launcher code. Please review again. Thx.

Copy link
Contributor

@rsn8887 rsn8887 left a comment

Looks almost good to merge, but please handle param2 coming before param1?

char path[256];
char game_id[64];
param1 += 7;
memcpy(path, param1, param2 - param1);

This comment has been minimized.

@rsn8887

rsn8887 Nov 9, 2020
Contributor

Don't subtract pointers like this, what if param2 comes before param1? please find a less hacky way, or an extra check to make sure param2 comes after.

char game_id[64];
param1 += 7;
memcpy(path, param1, param2 - param1);
path[param2-param1] = 0;

This comment has been minimized.

@rsn8887

rsn8887 Nov 9, 2020
Contributor

Please don't subtract pointers like this, what if param2 comes before param1 in the string? Use a less hacky way if possible. Thank you.

@rsn8887
Copy link
Contributor

@rsn8887 rsn8887 commented Nov 9, 2020

I reviewed it, please update, and if it is ok, I will merge.

@cy33hc
Copy link
Author

@cy33hc cy33hc commented Nov 9, 2020

@rsn8887 good point. I'll have that fixed.

@rsn8887
Copy link
Contributor

@rsn8887 rsn8887 commented Nov 10, 2020

Awesome, thanks! One last request, can you squash commits so there's only one commit called VITA: add support for booting via bubble

@cy33hc
Copy link
Author

@cy33hc cy33hc commented Nov 10, 2020

@rsn8887 I messed up the squash. I'll abandon the PR and create again.

@cy33hc cy33hc closed this Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.