Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI: Retain scroll position when deleting a save #2628

Merged
merged 1 commit into from Nov 22, 2020

Conversation

@sluicebox
Copy link
Member

@sluicebox sluicebox commented Nov 17, 2020

Currently, deleting a save game resets the scroll position, scrolling the list to the very top. This isn't noticeable if there's not many saves, but once there's a lot it's a pain to delete save 72, get kicked back to the beginning, and then try to find where you were again. This happens to me frequently. It doesn't look like the current behavior is intentional and I think it's reasonable to expect the list to be stable when deleting.

@criezy
Copy link
Member

@criezy criezy commented Nov 22, 2020

I agree that this is a better behaviour. Thanks for the PR!

@criezy criezy merged commit 6d3ed42 into scummvm:master Nov 22, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deepcode-ci-bot Well done, no issues found!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.