Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STARTREK: Additional detection entries #2630

Merged
merged 2 commits into from Nov 22, 2020
Merged

Conversation

@eriktorbjorn
Copy link
Member

@eriktorbjorn eriktorbjorn commented Nov 18, 2020

This adds some detection entries to the Star Trek engine, though I'm not sure whether or not they should be labelled floppy versions or not.

  • English Star Trek: 25th Anniversary included on Interplay's 10 Year Anniversary: Classic Collection.
  • English Star Trek: Judgment Rites included on The White Label - Doubles
  • French Star Trek: Judgment Rites included on The White Label - Doubles

So are they floppy versions? Well, none of them have speech at least.

The White Label CD contains three versions of Judgment Rites: English, German (already detected by ScummVM, albeit as a CD version) and French. Each folder takes up about 44 MB on the CD, for a total of about 133 MB. (The 25th Anniversary CD also has English, German and French versions, but they are all detected by ScummVM. I think the speech is English only.) This may be a bit large for a floppy game? Though if I run the included HD installer, I only get a 27 MB folder on my hard drive since there is a RITES.RNC file (18 MB) that it doesn't copy. Could that be a compressed archive of the other files?

The 10 Year Anthology contains one version of Star Trek: 25th Anniversary. The folder is about 7.2 MB on the CD.

I also have the Macintosh versions on CD, but I may need help if I'm to provide detection entries for those.

The 25th Anniversary CD has a "Voice Data" folder that should be simple enough to copy, but I'm guessing the rest of the files are bundled up in a "Star Trek CD-ROM Installer" thing, so that one probably needs to be run through a Mac emulator.

The Judgment Rites CD has "Movies" and "Speech" folders, with the rest presumably being bundled up into an "Install Star Trek JR" thing. My copy includes a bonus disc with interviews etc. (presumably the same as the bonus disc from the DOS version), but I assume that's outside the scope of this engine.

This one comes from Interplay's 10 Year Anniversary Anthology:
Classic Collection. Unfortunately, it only gets partway through
the intro before erroring out with "Tried to access file index 6
for file 'credit00.shp', which doesn't exist".
This is, I think, the English and French floppy versions of
Judgment Rites. They were included with The White Label Doubles
collection, along with the talkie version of 25th Anniversary.
Unexpected, but a pleasant surprise since I already had the
talkie version of Judgment Rites.

The CD also contains a German version, but ScummVM already
(mis)identifies that one as the German CD version.
@sev-
Copy link
Member

@sev- sev- commented Nov 18, 2020

Why not name them "10 Year Anniversary" and "White Label - Doubles" respectively?

@eriktorbjorn
Copy link
Member Author

@eriktorbjorn eriktorbjorn commented Nov 18, 2020

Maybe, but I don't know if they're unique to these collections. As I mentioned, the German version from my White Label CD was already detected. I submitted this since there's been some recent activity in the engine mainly to point out their existence. After that, I'm trusting whoever's working on the engine to fix them up to his or her liking.

@bluegr
Copy link
Member

@bluegr bluegr commented Nov 22, 2020

Thanks for the entries!

The rule of thumb is: only the CD-ROM versions had voice acting, usually located in a separate folder. So the ones you added are the floppy versions. You need to use the respective installer to install the games and unpack the actual game data.

Merging

@bluegr bluegr merged commit 3a36d82 into scummvm:master Nov 22, 2020
1 of 2 checks passed
1 of 2 checks passed
deepcode-ci-bot DeepCode is checking for issues.
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@eriktorbjorn
Copy link
Member Author

@eriktorbjorn eriktorbjorn commented Nov 23, 2020

I've checked again with DOSBox just to be sure, and neither the 25th Anniversary nor Judgment Rites have voices. Well, except for the "Space... The Final Frontier" speech at the beginning of Judgment Rites. Oddly enough, the French version has this speech in French, while the German version uses the English version. And, as I mentioned, ScummVM already detected this German version as "Star Trek: Judgment Rites (CD/DOS/German)". So I guess that detection entry is either wrong or ambiguous? Was there a German talkie version?

The Judgment Rites CD has the option of either installing the files to hard disk or run the game from the CD. The "Anniversary" CD installer copies the game to hard disk, but there is no unpacking involved: The files on your hard disk are identical to the ones on the CD.

By the way, I was able to run the installers for the Macintosh version in an emulator, but I guess supporting those versions isn't a priority right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.