Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCUMM: COMI: prevent SFX and VOICE from using fade-in #2631

merged 2 commits into from Nov 22, 2020


Copy link

@AndywinXp AndywinXp commented Nov 18, 2020

This commit fixes an oversight in which I allowed fade-ins for every track, regardless of their type (VOICE, SFX and MUSIC).
Now, fade-ins at sound start are allowed for music tracks only.

Copy link

@deepcode-ci-bot deepcode-ci-bot bot commented Nov 18, 2020

Congratulations 🎉. DeepCode analyzed your code in 2.214 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@aquadran aquadran merged commit 3d9a886 into scummvm:master Nov 22, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
deepcode-ci-bot Well done, no issues found!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.