Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI: Don't leak theme and TextDrawData when loading fails #2658

Merged
merged 1 commit into from Feb 17, 2021

Conversation

@lephilousophe
Copy link
Member

@lephilousophe lephilousophe commented Dec 1, 2020

This was spotted with a FreeType disabled build and with Address Sanitizer

@lephilousophe lephilousophe requested a review from sev- Dec 1, 2020
gui/ThemeEngine.cpp Show resolved Hide resolved
@criezy
Copy link
Member

@criezy criezy commented Feb 17, 2021

Merging this now.

@criezy criezy merged commit 577322f into scummvm:master Feb 17, 2021
2 of 3 checks passed
2 of 3 checks passed
deepcode-ci-bot DeepCode is checking for issues.
Codacy Static Code Analysis Codacy Static Code Analysis
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lephilousophe lephilousophe deleted the lephilousophe:fix-leaks branch Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants