Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI: Reflect default Gfx/Stretch Mode immediately #2690

Merged
merged 1 commit into from Dec 29, 2020

Conversation

av-dx
Copy link
Contributor

@av-dx av-dx commented Dec 17, 2020

Fix for issue #11744, with similar fix for updating graphics mode as well.

Selecting "<default>" for "Graphics Mode" and "Stretch Mode" and clicking "Apply" under Options...->Graphics now immediately reflects the changes in ScummVM window.

@lotharsm
Copy link
Member

Could you please fix the commit message according to our standards, so it reads GUI: Refresh Gfx/Strech mode when...?

Besides that, looking good to me.

@av-dx av-dx force-pushed the fix-gfx-stretch-modes-update-on-apply branch from 3f8a406 to ea26d4c Compare December 19, 2020 19:45
@av-dx
Copy link
Contributor Author

av-dx commented Dec 19, 2020

Yes, I have fixed the commit message now.

gui/options.cpp Show resolved Hide resolved
Copy link
Member

@criezy criezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are straightforward enough and make sense.
Thank you for this pull request, I will merge this now.

@criezy criezy merged commit 44045c2 into scummvm:master Dec 29, 2020
@av-dx av-dx deleted the fix-gfx-stretch-modes-update-on-apply branch January 5, 2021 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants