Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYMBIAN: Global Main Menu called with asterisk. #2709

Merged
merged 1 commit into from Jan 24, 2021
Merged

Conversation

@fedor4ever
Copy link
Contributor

@fedor4ever fedor4ever commented Jan 1, 2021

SYMBIAN: call main menu by key asterisk.

Replace hotkeys for calling main menu by asterisk because that used long ago. Asterisk used to call main menu because it presen on phone keyboard. On devices with touchscreen symbian sdl backend provides screen keyboard with several layouts with that key.

@ccawley2011
Copy link
Member

@ccawley2011 ccawley2011 commented Jan 1, 2021

A better way of doing this would be to override the getKeymapperDefaultBindings method in OSystem_SDL_Symbian, and setting the default binding there. The Android backend has an example of how to do this here.

@sev-
Copy link
Member

@sev- sev- commented Jan 1, 2021

Indeed. This PR needs to be reworked.

@fedor4ever
Copy link
Contributor Author

@fedor4ever fedor4ever commented Jan 1, 2021

@deepcode-ci-bot
Copy link

@deepcode-ci-bot deepcode-ci-bot bot commented Jan 1, 2021

Congratulations 🎉. DeepCode analyzed your code in 2.423 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@fedor4ever
Copy link
Contributor Author

@fedor4ever fedor4ever commented Jan 1, 2021

delay due compilation error

@fedor4ever
Copy link
Contributor Author

@fedor4ever fedor4ever commented Jan 1, 2021

Is scummvm itself free KeymapperDefaultBindings object? If no why other ports doesnt free?

@sev-
Copy link
Member

@sev- sev- commented Jan 24, 2021

Thanks!

@sev- sev- merged commit dcdd302 into scummvm:master Jan 24, 2021
3 checks passed
3 checks passed
Codacy Static Code Analysis Codacy Static Code Analysis
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deepcode-ci-bot Well done, no issues found!
Details
@fedor4ever fedor4ever deleted the fedor4ever:Global_Main_Menu branch Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants