Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI: fix compilation error. #2712

Open
wants to merge 1 commit into
base: master
from

Conversation

@fedor4ever
Copy link
Contributor

@fedor4ever fedor4ever commented Jan 2, 2021

And style fix.

I wonder how long that error lives?
GCC output:
/Symbian/Projects/SDL/scummvm/gui/KeysDialog.cpp: In constructor 'GUI::KeysDialog::KeysDialog(const Common::U32String&)':
/Symbian/Projects/SDL/scummvm/gui/KeysDialog.cpp:62:25: error: no matching function for call to 'GUI::ListWidget::setList(GUI::ListWidget::StringArray&)'
_actionsList->setList(l);
^
In file included from /Symbian/Projects/SDL/scummvm/gui/KeysDialog.h:32:0,
from /Symbian/Projects/SDL/scummvm/gui/KeysDialog.cpp:23:
/Symbian/Projects/SDL/scummvm/gui/widgets/list.h:101:7: note: candidate: void GUI::ListWidget::setList(const U32StringArray&, const ColorList*)
void setList(const U32StringArray &list, const ColorList *colors = nullptr);
^~~~~~~
/Symbian/Projects/SDL/scummvm/gui/widgets/list.h:101:7: note: no known conversion for argument 1 from 'GUI::ListWidget::StringArray {aka Common::ArrayCommon::String}' to 'const U32StringArray& {aka const Common::ArrayCommon::U32String&}'

And style fix.

I wonder how long that error lives?
GCC output:
/Symbian/Projects/SDL/scummvm/gui/KeysDialog.cpp: In constructor 'GUI::KeysDialog::KeysDialog(const Common::U32String&)':
/Symbian/Projects/SDL/scummvm/gui/KeysDialog.cpp:62:25: error: no matching function for call to 'GUI::ListWidget::setList(GUI::ListWidget::StringArray&)'
  _actionsList->setList(l);
                         ^
In file included from /Symbian/Projects/SDL/scummvm/gui/KeysDialog.h:32:0,
                 from /Symbian/Projects/SDL/scummvm/gui/KeysDialog.cpp:23:
/Symbian/Projects/SDL/scummvm/gui/widgets/list.h:101:7: note: candidate: void GUI::ListWidget::setList(const U32StringArray&, const ColorList*)
  void setList(const U32StringArray &list, const ColorList *colors = nullptr);
       ^~~~~~~
/Symbian/Projects/SDL/scummvm/gui/widgets/list.h:101:7: note:   no known conversion for argument 1 from 'GUI::ListWidget::StringArray {aka Common::Array<Common::String>}' to 'const U32StringArray& {aka const Common::Array<Common::U32String>&}'
@sev-
Copy link
Member

@sev- sev- commented Jan 2, 2021

Shouldn't KeysDialog be killed completely and the currently implemented Keymapper is used?

@fedor4ever
Copy link
Contributor Author

@fedor4ever fedor4ever commented Jan 2, 2021

That be done in migration from actions system, right?

@sev-
Copy link
Member

@sev- sev- commented Jan 2, 2021

I do not understand your question. Old Symbain keymapper should be better fully removed and the global keymapper used. Otherwise, in the GUI there will be two keymappers.

@fedor4ever
Copy link
Contributor Author

@fedor4ever fedor4ever commented Jan 2, 2021

When I asked, I thought about that pr - #2367, which deprecates action system for symbian.

@sev-
Copy link
Member

@sev- sev- commented Jan 2, 2021

Yes, see this warning: https://github.com/scummvm/scummvm/blob/master/gui/KeysDialog.cpp#L27

So, instead of fixing the compilation, this file should be just removed completely. It was not done in the initial PR because of the build subsystem for Symbian.

@fedor4ever
Copy link
Contributor Author

@fedor4ever fedor4ever commented Jan 2, 2021

Other files in symbian port with that warnig should be removed too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.