SCI: Hebrew in parentheses isn't stage direction #2726
Merged
Conversation
|
Just a few pics to illustrate the point: Prior the fix:
After the fix:
Original:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Before this PR, Hebrew text in parentheses was treated as stage direction (because it doesn't contain English lower case letters, and usually doesn't contain digits), and wasn't printed.
This PR makes Hebrew letters behave similar to English lower case letters - if they exist - print the message.
(There is no point in translating the stage direction to Hebrew, if ever there will be a Hebrew dubbing project, the actors will use the English directions...)
This PR is coordinated with the group that translated previous Sierra titles to Hebrew (Torin, GK2, SQ3), and working now on QFG1VGA - that's were we understood that problem. In previous titles, the text in parentheses wasn't translated at all, thus, this fix won't make any unwanted text to start appearing.