Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCI: Hebrew in parentheses isn't stage direction #2726

Merged
merged 1 commit into from Jan 11, 2021

Conversation

@ZvikaZ
Copy link
Contributor

@ZvikaZ ZvikaZ commented Jan 10, 2021

Before this PR, Hebrew text in parentheses was treated as stage direction (because it doesn't contain English lower case letters, and usually doesn't contain digits), and wasn't printed.

This PR makes Hebrew letters behave similar to English lower case letters - if they exist - print the message.
(There is no point in translating the stage direction to Hebrew, if ever there will be a Hebrew dubbing project, the actors will use the English directions...)

This PR is coordinated with the group that translated previous Sierra titles to Hebrew (Torin, GK2, SQ3), and working now on QFG1VGA - that's were we understood that problem. In previous titles, the text in parentheses wasn't translated at all, thus, this fix won't make any unwanted text to start appearing.

@noomorph
Copy link

@noomorph noomorph commented Jan 10, 2021

Just a few pics to illustrate the point:

Prior the fix:

image

After the fix:

image

Original:

image

engines/sci/engine/message.cpp Outdated Show resolved Hide resolved
@ZvikaZ ZvikaZ force-pushed the ZvikaZ:z_heb_parenth branch from 92a6a65 to 08692a4 Jan 10, 2021
engines/sci/engine/message.cpp Outdated Show resolved Hide resolved
@ZvikaZ ZvikaZ force-pushed the ZvikaZ:z_heb_parenth branch from 08692a4 to 55157b9 Jan 11, 2021
@bluegr bluegr merged commit a5d0077 into scummvm:master Jan 11, 2021
3 checks passed
3 checks passed
Codacy Static Code Analysis Codacy Static Code Analysis
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deepcode-ci-bot Well done, no issues found!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.