Skip to content

/ scummvm

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BACKENDS: search also for track_x and track_xx audio cd tracks #2730

Open
wants to merge 1 commit into
base: master
from
Open

BACKENDS: search also for track_x and track_xx audio cd tracks #2730

wants to merge 1 commit into from
+7 −4

Conversation

@mgerhardy
Copy link
Contributor

@mgerhardy mgerhardy commented Jan 13, 2021 •
edited

this allows us to use the unmodified version of dotemu lba1 enhanced music track paths

see 1b67a28
@deepcode-ci-bot
Copy link

@deepcode-ci-bot deepcode-ci-bot bot commented Jan 13, 2021 •
edited

Congratulations 🎉. DeepCode analyzed your code in 2.061 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot
@mgerhardy
Copy link
Contributor Author

@mgerhardy mgerhardy commented Jan 14, 2021

Maybe the buffer should get increased or snprintf should be used. track_2147483648 would overflow the buffer by 1 byte
@mgerhardy
BACKENDS: search also for track_x and track_xx audio cd tracks
Loading status checks…
7933210 
this allows us to use the unmodified version of dotemu lba1 enhanced music track paths
@mgerhardy mgerhardy force-pushed the mgerhardy:pr/audio-cd-file-pattern branch from fdb265d to 7933210 Jan 15, 2021
@mgerhardy
Copy link
Contributor Author

@mgerhardy mgerhardy commented Jan 15, 2021

Using Common::String::format now - still fits into the internal buffer, so no mem allocations - openStreamFile was converting it into a Common::String anyway. Also replaced the hardcoded arraysize.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
@mgerhardy
You can’t perform that action at this time.