Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCUMM: Digital iMUSE: fix FT crash and music breaking bug #2741

Merged
merged 2 commits into from Feb 17, 2021

Conversation

@AndywinXp
Copy link
Contributor

@AndywinXp AndywinXp commented Jan 23, 2021

This is an urgent fix which is contained in PR #2701. Since that PR is quite big and it's taking some time to be approved, and since people are rightfully telling me that FT is currently broken in the current dev build, I'm sending these urgent fixes as a separate PR.

Please merge this as soon as you can, since this fixes Full Throttle crashing and another bug in COMI which allowed zero volume (toBeRemoved) tracks to be able to make JUMPs and loops before being flushed.

@criezy
Copy link
Member

@criezy criezy commented Feb 17, 2021

I missed that one. I am guessing it fixes bug #12156.
Let's merge.

@criezy criezy merged commit bb48639 into scummvm:master Feb 17, 2021
3 checks passed
3 checks passed
Codacy Static Code Analysis Codacy Static Code Analysis
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deepcode-ci-bot Well done, no issues found!
Details
@criezy
Copy link
Member

@criezy criezy commented Feb 17, 2021

And indeed it fixes the aforementioned bug. Thank you!

@AndywinXp
Copy link
Contributor Author

@AndywinXp AndywinXp commented Feb 17, 2021

Thanks @criezy ! 🙏

@lgRecip
Copy link

@lgRecip lgRecip commented Feb 17, 2021

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants