Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL: Fix trying to set unsupported pixel format when changing gfx mode #2744

Merged
merged 1 commit into from Feb 8, 2021

Conversation

@criezy
Copy link
Member

@criezy criezy commented Jan 24, 2021

When switching between the SDL and OpenGL graphics managers, trying to restore the state could fail as the two managers do not have the same list of supported formats, so we may not be able to transfer the pixel format from one to the other. This then resulted in an assert.

This fixes bug #12079.

I am not sure the way I fixed it is the best way to do it. So I am opening that pull request for review before merging.

When switching between the SDL and OpenGL graphics managers, trying
to restore the state could fail as the two managers do not have the
same list of supported formats, so we may not be able to transfer
the pixel format from one to the other. This then resulted in an
assert.

This fixes bug #12079
@criezy
Copy link
Member Author

@criezy criezy commented Feb 8, 2021

Merging this now. I am not particularly happy with the solution, but after two weeks I still don't have a better idea.

@criezy criezy merged commit 5412533 into scummvm:master Feb 8, 2021
3 checks passed
3 checks passed
Codacy Static Code Analysis Codacy Static Code Analysis
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deepcode-ci-bot Well done, no issues found!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant