Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AUDIO: Combine WaveFormat enums under one header #2753

Merged
merged 2 commits into from Feb 5, 2021
Merged

Conversation

@SupSuper
Copy link
Contributor

@SupSuper SupSuper commented Feb 5, 2021

I noticed the A/V code duplicates the WAV Format Tags multiple times, so I combined all of them into the common wave_types.h header, as this should make it easier to add new formats in the future and avoid conflicts.

Dunno if decimal or hexadecimal is better, but since the format specification uses hexadecimal I went with that.

@bluegr
Copy link
Member

@bluegr bluegr commented Feb 5, 2021

Quite a straightforward change, and makes perfect sense. Thanks for your work on this! Merging

@bluegr bluegr merged commit 1b2e0b7 into scummvm:master Feb 5, 2021
3 checks passed
3 checks passed
Codacy Static Code Analysis Codacy Static Code Analysis
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deepcode-ci-bot Well done, no issues found!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants