AUDIO: Combine WaveFormat enums under one header #2753
Merged
Conversation
|
Quite a straightforward change, and makes perfect sense. Thanks for your work on this! Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
I noticed the A/V code duplicates the WAV Format Tags multiple times, so I combined all of them into the common
wave_types.hheader, as this should make it easier to add new formats in the future and avoid conflicts.Dunno if decimal or hexadecimal is better, but since the format specification uses hexadecimal I went with that.