BASE: Avoid calling PluginMan.getEngineFromMetaEngine where possible #2754
+57
−72
Conversation
|
Many Thanks! It works perfectly with the WII build. A thumbs up from me for merging. |
|
Some engines support return to launcher. After going back to the launcher, no more games can be started. It indicates that the game engine cannot be found. Only restarting ScummVM solves the problem. Does that have anything to do with these changes? |
|
This has conflicts and can no longer be merged. @ccawley2011 could you please rebase your changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This fixes Trac #12016 by having the engine hold a pointer to the MetaEngine instance, rather than looking it up again when it's needed.