Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BASE: Avoid calling PluginMan.getEngineFromMetaEngine where possible #2754

Open
wants to merge 1 commit into
base: master
from

Conversation

@ccawley2011
Copy link
Member

@ccawley2011 ccawley2011 commented Feb 5, 2021

This fixes Trac #12016 by having the engine hold a pointer to the MetaEngine instance, rather than looking it up again when it's needed.

@ccawley2011 ccawley2011 force-pushed the ccawley2011:getMetaEngine branch from 9109f91 to 106640b Feb 6, 2021
@AReim1982
Copy link
Contributor

@AReim1982 AReim1982 commented Feb 8, 2021

Many Thanks! It works perfectly with the WII build. A thumbs up from me for merging.

@AReim1982
Copy link
Contributor

@AReim1982 AReim1982 commented Feb 10, 2021

Some engines support return to launcher. After going back to the launcher, no more games can be started. It indicates that the game engine cannot be found. Only restarting ScummVM solves the problem. Does that have anything to do with these changes?

@bluegr
Copy link
Member

@bluegr bluegr commented Feb 15, 2021

This has conflicts and can no longer be merged. @ccawley2011 could you please rebase your changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants