Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONFIGURE: Update config.* to latest version #2755

Merged
merged 1 commit into from Feb 17, 2021

Conversation

@lephilousophe
Copy link
Member

@lephilousophe lephilousophe commented Feb 7, 2021

New version handles Darwin arm64

New version handles darwin arm64
@criezy
Copy link
Member

@criezy criezy commented Feb 8, 2021

Building works fine on a mac M1 both with and without this change. So it's fine with me.
Can you clarify what are the benefit? The only difference I have noticed is that the host CPU architecture is recognised as aarch64 instead of arm, but this doesn't seem to make much of a difference in the end.

@lephilousophe
Copy link
Member Author

@lephilousophe lephilousophe commented Feb 10, 2021

It's just this.
As @sev- already updated this code on a regular basis, I thought it was fine to do it but buildbot can live without it.
It currently uses aarch64 prefix.

@criezy
Copy link
Member

@criezy criezy commented Feb 17, 2021

Yes, it's fine to update that code. Merging.

@criezy criezy merged commit 99dc24f into scummvm:master Feb 17, 2021
3 checks passed
3 checks passed
Codacy Static Code Analysis Codacy Static Code Analysis
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deepcode-ci-bot Well done, no issues found!
Details
@lephilousophe lephilousophe deleted the lephilousophe:update-config branch Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants