Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AGS: Add detection entries for 'Unavowed (English/Windows)' #2756

Merged
merged 1 commit into from Feb 7, 2021

Conversation

@lotharsm
Copy link
Member

@lotharsm lotharsm commented Feb 7, 2021

This patch adds an detection entry for the Windows release of "Unavowed" available at Steam and GoG.

The came is currently unable to launch and fails with the following stacktrace:
https://paste.ubuntu.com/p/zT8KCCH9wk/

@lotharsm lotharsm requested a review from dreammaster Feb 7, 2021
@lotharsm lotharsm merged commit a4827e3 into scummvm:master Feb 7, 2021
3 checks passed
3 checks passed
Codacy Static Code Analysis Codacy Static Code Analysis
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deepcode-ci-bot Well done, no issues found!
Details
@lotharsm lotharsm deleted the lotharsm:ags-unavowed-detection branch Feb 7, 2021
@raziel-
Copy link
Contributor

@raziel- raziel- commented Feb 7, 2021

I didn't know two files with different sizes can have the exact same md5sum...nice

@lephilousophe
Copy link
Member

@lephilousophe lephilousophe commented Feb 7, 2021

md5 checksum is computed only on first 5000 bytes

@raziel-
Copy link
Contributor

@raziel- raziel- commented Feb 7, 2021

@lephilousophe

D'oh...I mean, I knew that :-D

Just ignore me... :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants