Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AGS: Plugin stubs for Nickenstien's NGFX Graphics Library #2767

Open
wants to merge 1 commit into
base: master
from

Conversation

@kyandora
Copy link
Contributor

@kyandora kyandora commented Feb 12, 2021

This pull request adds stubs for Nickenstien's NGFX Graphics Library used by Size Five Games' Time Gentlemen, Please! (timegentlemenplease). ScummVM now proceeds in-game instead of immediately crashing.

Copy link
Member

@dreammaster dreammaster left a comment

I would actually prefer any such plugins added follow the new style I'm promoting, where each plugin derives from the DLL class, and implements all the methods separately, to make it easier if we later decide to implement the contents. Particularly in cases like this.. from the names of methods, the library provides various effects that we may have to eventually reverse engineer and re-implement, so it'll simplify matters if there are already methods in place we can just put the contents into.

Just look at some of the other plugins for the example of how the methods are defined, and the parameters are extracted.

@kyandora kyandora force-pushed the kyandora:ags_nickenstien branch from 6668ae1 to 70bf66b Feb 12, 2021
@kyandora kyandora requested a review from dreammaster Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants