ENGINES: Make creation of savegame thumbnails an overrideable method #2770
Conversation
Nice change - I could use this for twine, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
I think this is a straightforward minor change, but since it touches the engine base, I thought I'd do a pull request for a quick review.
This change changes the methods for appending the new style extra savegame info to instance methods, and the method that generates the thumbnail a virtual method. This will allow engines to override the method in their own meta engine subclass, and do things like create a thumbnail without any on-screen dialogs showing.