Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENGINES: Make creation of savegame thumbnails an overrideable method #2770

Open
wants to merge 1 commit into
base: master
from

Conversation

@dreammaster
Copy link
Member

@dreammaster dreammaster commented Feb 13, 2021

I think this is a straightforward minor change, but since it touches the engine base, I thought I'd do a pull request for a quick review.

This change changes the methods for appending the new style extra savegame info to instance methods, and the method that generates the thumbnail a virtual method. This will allow engines to override the method in their own meta engine subclass, and do things like create a thumbnail without any on-screen dialogs showing.

@mgerhardy
Copy link
Contributor

@mgerhardy mgerhardy commented Feb 13, 2021

Nice change - I could use this for twine, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants