Skip to content

/ scummvm

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AGS: Update detection_tables.h #2772

Closed
wants to merge 6 commits into from
Closed

AGS: Update detection_tables.h #2772

wants to merge 6 commits into from

Conversation

@berianwilliams
Copy link

@berianwilliams berianwilliams commented Feb 13, 2021

Bought every commercial AGS game on Steam, scanned and added.
@berianwilliams
Update detection_tables.h
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
13720eb 
Bought every commercial AGS game on Steam, scanned and added.
@dreammaster
Copy link
Member

@dreammaster dreammaster commented Feb 13, 2021

AGA will be doing some further additions and fix the commit prefix tomorrow
@SupSuper
Copy link
Contributor

@SupSuper SupSuper commented Feb 14, 2021

There's a bunch of duplicate gameid entries which should be cleaned up.
@SupSuper
SupSuper reviewed Feb 14, 2021
View changes
engines/ags/detection_tables.h
ENGLISH_ENTRY("shardlight", "Shardlight.exe", "ee801fba52d252249677a9170bd2db96", 642157876), // Steam
ENGLISH_ENTRY("shardlight", "shardlight.exe", "ee801fba52d252249677a9170bd2db96", 642157876), // Steam

This comment has been minimized.

Sign in to view
@SupSuper

SupSuper Feb 14, 2021
Contributor

Duplicate? I think ScummVM is case-insensitive.

This comment has been minimized.

Sign in to view
@sev-

sev- Feb 15, 2021
Member

Yes, ScummVM is case-insensitive for the file names. Perhaps we would need to improve the scan tool
@sev-
Copy link
Member

@sev- sev- commented Feb 15, 2021

The commit log message must have an engine prefix. Please see https://wiki.scummvm.org/index.php?title=Commit_Guidelines
@sev-
sev- reviewed Feb 15, 2021
View changes
engines/ags/detection_tables.h
ENGLISH_ENTRY("shardlight", "Shardlight.exe", "ee801fba52d252249677a9170bd2db96", 642157876), // Steam
ENGLISH_ENTRY("shardlight", "shardlight.exe", "ee801fba52d252249677a9170bd2db96", 642157876), // Steam
ENGLISH_ENTRY("shivah", "ac2game.dat", "0aaf5445a3544a631d6e7dd4561fc7ae", 32323040), // Steam
ENGLISH_ENTRY("shivah", "ac2game.dat", "bdc618b23fc279938f05f8ac058a938b", 32727114), // Steam

This comment has been minimized.

Sign in to view
@sev-

sev- Feb 15, 2021
Member

Is there a way to understand the version number, so you could put it in the comment?

This comment has been minimized.

Sign in to view
@berianwilliams

berianwilliams Feb 15, 2021
Author

The AGS editor does allow an author to specify a version number, but I'm not sure whether it's stored in any of the game files' headers?
@berianwilliams
Update detection_tables.h
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f9e91d5 
Added further Steam demos, and merged previous commits.
@deepcode-ci-bot
Copy link

@deepcode-ci-bot deepcode-ci-bot bot commented Feb 15, 2021 •
edited

Congratulations 🎉. DeepCode analyzed your code in 0.379 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot
@berianwilliams berianwilliams changed the title Update detection_tables.h AGS: Update detection_tables.h Feb 15, 2021
@berianwilliams
Merge branch 'master' into patch-1
Loading status checks…
b1d062a
@berianwilliams
Revert "Update detection_tables.h"
df07c6d 
This reverts commit f9e91d5.
@berianwilliams
Revert "Update detection_tables.h"
Loading status checks…
25ba9c7 
This reverts commit 13720eb.
@berianwilliams
AGS: added additional Steam commercial games
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
358d1de
criezy added a commit that referenced this pull request Feb 22, 2021
@criezy
AGS: Update detection entries
3310fa2 
This includes the Steam detection provided by Berian Williams (AGA)
in pull request #2772 and moves some detection entries to the
commercial games section.
@criezy
Copy link
Member

@criezy criezy commented Feb 22, 2021

Thank you for all those detection entries.
This pull request was rotting and had numerous conflicts so I manually added your detection manually (and moved some existing detection entries to the commercial game section) in 3310fa2.
@criezy criezy closed this Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sev- sev-

@SupSuper SupSuper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@berianwilliams @dreammaster @SupSuper @sev- @criezy