Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AGS: Update detection_tables.h #2772

Closed
wants to merge 6 commits into from

Conversation

@berianwilliams
Copy link

@berianwilliams berianwilliams commented Feb 13, 2021

Bought every commercial AGS game on Steam, scanned and added.

Bought every commercial AGS game on Steam, scanned and added.
@dreammaster
Copy link
Member

@dreammaster dreammaster commented Feb 13, 2021

AGA will be doing some further additions and fix the commit prefix tomorrow

@SupSuper
Copy link
Contributor

@SupSuper SupSuper commented Feb 14, 2021

There's a bunch of duplicate gameid entries which should be cleaned up.

ENGLISH_ENTRY("shardlight", "Shardlight.exe", "ee801fba52d252249677a9170bd2db96", 642157876), // Steam
ENGLISH_ENTRY("shardlight", "shardlight.exe", "ee801fba52d252249677a9170bd2db96", 642157876), // Steam

This comment has been minimized.

@SupSuper

SupSuper Feb 14, 2021
Contributor

Duplicate? I think ScummVM is case-insensitive.

This comment has been minimized.

@sev-

sev- Feb 15, 2021
Member

Yes, ScummVM is case-insensitive for the file names. Perhaps we would need to improve the scan tool

@sev-
Copy link
Member

@sev- sev- commented Feb 15, 2021

The commit log message must have an engine prefix. Please see https://wiki.scummvm.org/index.php?title=Commit_Guidelines

ENGLISH_ENTRY("shardlight", "Shardlight.exe", "ee801fba52d252249677a9170bd2db96", 642157876), // Steam
ENGLISH_ENTRY("shardlight", "shardlight.exe", "ee801fba52d252249677a9170bd2db96", 642157876), // Steam
ENGLISH_ENTRY("shivah", "ac2game.dat", "0aaf5445a3544a631d6e7dd4561fc7ae", 32323040), // Steam
ENGLISH_ENTRY("shivah", "ac2game.dat", "bdc618b23fc279938f05f8ac058a938b", 32727114), // Steam

This comment has been minimized.

@sev-

sev- Feb 15, 2021
Member

Is there a way to understand the version number, so you could put it in the comment?

This comment has been minimized.

@berianwilliams

berianwilliams Feb 15, 2021
Author

The AGS editor does allow an author to specify a version number, but I'm not sure whether it's stored in any of the game files' headers?

Added further Steam demos, and merged previous commits.
@deepcode-ci-bot
Copy link

@deepcode-ci-bot deepcode-ci-bot bot commented Feb 15, 2021

Congratulations 🎉. DeepCode analyzed your code in 0.379 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@berianwilliams berianwilliams changed the title Update detection_tables.h AGS: Update detection_tables.h Feb 15, 2021
This reverts commit 13720eb.
criezy added a commit that referenced this pull request Feb 22, 2021
This includes the Steam detection provided by Berian Williams (AGA)
in pull request #2772 and moves some detection entries to the
commercial games section.
@criezy
Copy link
Member

@criezy criezy commented Feb 22, 2021

Thank you for all those detection entries.
This pull request was rotting and had numerous conflicts so I manually added your detection manually (and moved some existing detection entries to the commercial game section) in 3310fa2.

@criezy criezy closed this Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants