Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AGS: Fix Android crash to OS on game launch #2774

Merged
merged 1 commit into from Feb 14, 2021

Conversation

@lowtraxx
Copy link
Contributor

@lowtraxx lowtraxx commented Feb 14, 2021

The Android NDK uses unsigned char by default. Fixed the decompression algorithm by replacing them with int8. Also not using the fixed PixelFormat with OpenGL as it is not supported there. These changes allow the Games to run, albeit with messed up colors.

@deepcode-ci-bot
Copy link

@deepcode-ci-bot deepcode-ci-bot bot commented Feb 14, 2021

Congratulations 🎉. DeepCode analyzed your code in 0.544 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

engines/ags/ags.cpp Outdated Show resolved Hide resolved
@lowtraxx lowtraxx force-pushed the lowtraxx:bugfix_ags_android branch from eb17f06 to 4379a09 Feb 14, 2021
@antoniou79
Copy link
Contributor

@antoniou79 antoniou79 commented Feb 14, 2021

Looks good to me.

@lowtraxx lowtraxx requested a review from lephilousophe Feb 14, 2021
@lephilousophe
Copy link
Member

@lephilousophe lephilousophe commented Feb 14, 2021

LGTM but I am not the most relevant on this PR.

engines/ags/ags.cpp Outdated Show resolved Hide resolved
Copy link
Member

@criezy criezy left a comment

The char to int8 change makes perfect sense.

I am not sure about the changes to the pixel formats though, and I have added relevant comments on the changes.

engines/ags/ags.cpp Outdated Show resolved Hide resolved
engines/ags/lib/allegro/gfx.cpp Outdated Show resolved Hide resolved
@lowtraxx lowtraxx force-pushed the lowtraxx:bugfix_ags_android branch from 4379a09 to 211fbe8 Feb 14, 2021
@lowtraxx lowtraxx force-pushed the lowtraxx:bugfix_ags_android branch from 211fbe8 to bc8157f Feb 14, 2021
@criezy
Copy link
Member

@criezy criezy commented Feb 14, 2021

Thank you for moving the pixel format change to a separate pull request.
This one can be merged now.

@criezy criezy merged commit b27dd08 into scummvm:master Feb 14, 2021
3 checks passed
3 checks passed
Codacy Static Code Analysis Codacy Static Code Analysis
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deepcode-ci-bot Well done, no issues found!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants