AGS: Fix Android crash to OS on game launch #2774
Merged
+3
−3
Conversation
|
|
|
Looks good to me. |
|
LGTM but I am not the most relevant on this PR. |
|
The I am not sure about the changes to the pixel formats though, and I have added relevant comments on the changes. |
|
Thank you for moving the pixel format change to a separate pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The Android NDK uses unsigned char by default. Fixed the decompression algorithm by replacing them with int8. Also not using the fixed PixelFormat with OpenGL as it is not supported there. These changes allow the Games to run, albeit with messed up colors.