Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMMON: Specialize unknownKeyError for more types #2788

merged 2 commits into from Feb 21, 2021


Copy link

@henke37 henke37 commented Feb 21, 2021

Gives better error messages if someone is using const char* as the hashmap Key.

@henke37 henke37 force-pushed the henke37:constCharKeyErr branch from 774cb3b to 3f12336 Feb 21, 2021
@henke37 henke37 changed the title COMMON: Specialize unknownKeyError for const char* COMMON: Specialize unknownKeyError for more types Feb 21, 2021
@henke37 henke37 marked this pull request as ready for review Feb 21, 2021
criezy approved these changes Feb 21, 2021
Copy link

@criezy criezy left a comment

Thank you. Looks good.

@criezy criezy merged commit 6b2bf78 into scummvm:master Feb 21, 2021
2 of 3 checks passed
2 of 3 checks passed
deepcode-ci-bot DeepCode is checking for issues.
Codacy Static Code Analysis Codacy Static Code Analysis
continuous-integration/travis-ci/pr The Travis CI build passed
@henke37 henke37 deleted the henke37:constCharKeyErr branch Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants