Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCUMM: SMUSH: always enable line wrap on hebrew fan translation #2791

Open
wants to merge 1 commit into
base: master
from

Conversation

@BLooperZ
Copy link
Contributor

@BLooperZ BLooperZ commented Feb 21, 2021

In Hebrew there are no distinction between capital/small letters,
which results in wider text that although originally was able to fit in screen width, usually go beyond the width of the screen in translation.
This may be the easier way to solve this and it doesn't seem to have negative side effect.
(the other way is to change the text flag in all animation files)

Thanks

@BLooperZ BLooperZ force-pushed the BLooperZ:smush_he_linewrap branch from da121bd to 70f5f13 Feb 21, 2021
@BLooperZ BLooperZ requested a review from bluegr Feb 21, 2021
@athrxx
Copy link
Member

@athrxx athrxx commented Feb 22, 2021

I am not familiar with the Hebrew fan translation, but maybe you need the same modification in insane.cpp, line 1305, too. Please check...

@BLooperZ
Copy link
Contributor Author

@BLooperZ BLooperZ commented Feb 22, 2021

Thanks, will check that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants