Could you rename this commit to conform to the guidelines? https://wiki.scummvm.org/index.php/Commit_Guidelines
The prefix should be COMMON since this doesn't touch the Pegasus engine. The summary should describe the change as opposed to just a bug number.
I'm confused if this reverts 1bb7386 or not. Do ISOBuster files still work? That commit commented out a line and added the comment "Files produced by ISOBuster are not padded, thus, compare with the actual size", this PR restores the line but leaves that comment, and that doesn't sound right.
My interest is so that our tester who uses ISOBuster can still test my Mac stuff =)
criezy left a comment •
It seems to me that your change will completely break reading macbinary files (created by ISOBuster or not).
The cleaning in the code is good. But the logic for the two checks in
And as @sluicebox pointed out, the commit message is also incorrect. The prefix should be
I have also requested a review from @sev-
if (MBI_INFOHDR + dataSizePad + rsrcSize == (uint32)stream.size() || MBI_INFOHDR + dataSizePad + rsrcSizePad == (uint32)stream.size())