Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCUMM: Fix verb selection on overlapping verbs #2800

Open
wants to merge 1 commit into
base: master
from

Conversation

@orgads
Copy link
Contributor

@orgads orgads commented Feb 23, 2021

On COMI, verbs can vertically overlap. For example, verb 1 is 330-360
and verb 2 is 354-384.

Highlighting is done by the first match, but clicking chooses the last
one, as it is scanned backwards.

So if the mouse is in range 354-360, the highlighted text is not picked.

@orgads
Copy link
Contributor Author

@orgads orgads commented Feb 23, 2021

I have to admit I couldn't find where the highlighting part is different (looks like it also uses findVerbAtPos), but this behavior is consistent.

@orgads
Copy link
Contributor Author

@orgads orgads commented Feb 23, 2021

@orgads
Copy link
Contributor Author

@orgads orgads commented Feb 23, 2021

Oops, should start from 1. I'll fix it tomorrow.

Do you have other comments?

On COMI, verbs can vertically overlap. For example, verb 1 is 330-360
and verb 2 is 354-384.

Highlighting is done by the first match, but clicking chooses the last
one, as it is scanned backwards.

So if the mouse is in range 354-360, the highlighted text is not picked.
@orgads orgads force-pushed the orgads:scumm-highlighted branch from 0c8478d to 1a8a21b Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant