Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRIFFON: Adding TTS to Intro Story #2908

Closed
wants to merge 2 commits into from

Conversation

@taylorzhancher
Copy link

@taylorzhancher taylorzhancher commented Apr 2, 2021

By passing the words to Text To Speech Manager, this code allows TTS support to the beginning of the game.

@bluegr
Copy link
Member

@bluegr bluegr commented Apr 2, 2021

Thanks for your work! However, the way this is done, there is duplicate text for the intro. You could concatenate the existing story array items dynamically into a new string, and pass that to the TTS handler instead.

Also, the commit messages do not follow our guidelines - in this case, each commit should be prefixed with GRIFFON

@taylorzhancher
Copy link
Author

@taylorzhancher taylorzhancher commented Apr 2, 2021

@bluegr Thank you! Your instructions are helpful. I will come back with it fixed.

@sev-
Copy link
Member

@sev- sev- commented Apr 2, 2021

It would be great if other things like menus also have voice-overs.

Also, this is incomplete: this lacks the relevant GUI options, so it could not be added as-is.

And as it was discussed on the channel, the proper approach would be to feed TTS paragraph by paragraph, as they're displayed on the screen.

@bluegr
Copy link
Member

@bluegr bluegr commented Apr 5, 2021

This has been redone in #2912. Closing this one

@bluegr bluegr closed this Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants