Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAKEFILE: Add a dependency for rebuilding base/plugins when config is changed #2909

Merged
merged 1 commit into from Apr 3, 2021

Conversation

@orgads
Copy link
Contributor

@orgads orgads commented Apr 3, 2021

When adding/removing an engine, config.mk is changed, and this effectively
passes different -DENABLE_* command-line arguments to the compiler.

If base/plugins is not recompiled, the list of active plugins is not updated.

Before b813d1c config.h was created every
time configure was executed, so everything was recompiled anyway. Now we need
to have an explicit dependency.

The only source file that's supposed to be affected is base/plugins, so there
is no reason to rebuild everything. Just add this dependency to update the
plugin list.

… changed

When adding/removing an engine, config.mk is changed, and this effectively
passes different -DENABLE_* command-line arguments to the compiler.

If base/plugins is not recompiled, the list of active plugins is not updated.

Before b813d1c config.h was created every
time configure was executed, so everything was recompiled anyway. Now we need
to have an explicit dependency.

The only source file that's supposed to be affected is base/plugins, so there
is no reason to rebuild everything. Just add this dependency to update the
plugin list.
@sev- sev- merged commit bede68c into scummvm:master Apr 3, 2021
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
deepcode-ci-bot DeepCode is checking for issues.
Codacy Static Code Analysis Codacy Static Code Analysis
Details
@sev-
Copy link
Member

@sev- sev- commented Apr 3, 2021

Yay, thank you!

@orgads orgads deleted the orgads:plugin-dep branch Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants