Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AGI: fixed typo in music volume settings #2910

Merged
merged 1 commit into from Apr 4, 2021
Merged

Conversation

@ZvikaZ
Copy link
Contributor

@ZvikaZ ZvikaZ commented Apr 4, 2021

The typo caused music and sound effects volumes values to be swapped for PCjr (but not to MIDI, because sound_midi doesn't call MixerImpl::getVolumeForSoundType)

The typo caused music and sound effects volumes values to be swapped
@bluegr
Copy link
Member

@bluegr bluegr commented Apr 4, 2021

Nice catch! Thanks for spotting and fixing it. Merging

@bluegr bluegr merged commit 3eef29f into scummvm:master Apr 4, 2021
3 checks passed
3 checks passed
Codacy Static Code Analysis Codacy Static Code Analysis
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deepcode-ci-bot Well done, no issues found!
Details
@ZvikaZ ZvikaZ deleted the ZvikaZ:z_agi_volume branch Apr 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants