WIP: IMAGE: Gif decoder using stb_image #2911
Added a GIF decoder needed in LBA1 floppy disk version.
This is wrapping stb_image.h (https://github.com/nothings/stb/blob/master/stb_image.h)
Also see the related PR #2923 (Obviously only one should get merged)
True - would be nice. But I don't need this in TwinE - and I'm currently concentrating on the stuff that I need. This is an explicit check at the moment and it will print out a warning if the gif has more than 1 frame. Are there any engines out there, that need this?
I suppose implementing support for animated mng and gif might also need some kind of api change for the decoders api. This is currently out of scope of this PR.
I tried to add a simple unittest but running
@henke37 Why should we care about animated gifs in the first place? Your statement is absolutely out of place.
Also, it is not very pleasant to see thins kind of judgemental expressions. Why are you questioning the choice of words by a developer? Why are you reviewing this at all? We are looking for the team members' feedback, not from the outsiders.
The stb_image library supports a lot of functionality that's covered by other libraries, so we should only keep the parts that we need from it. Thankfully, it's possible to just enable the parts that are needed using ifdefs
The rest of the changes are straightforward, and are just fine to merge by me.
Regarding the supported file formats of this library:
Thus, at this point we'll only need the GIF functionality of this library, which is the only part of it that's enabled at the moment.
Overall, clean and simple implementation :) +1 from me