SCUMM: FM-TOWNS: Add optional trimming to 200 pixels height #2913
+99
−12
Conversation
Trimming the screen to 200 pixels allows using aspect ratio correction.
|
Thank you, this is a long-requested feature. Your implementation is clean and proper. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Trimming the screen to 200 pixels allows using aspect ratio correction.
Aspect ratio correction for FM-TOWNS has been requested for long time.
A discussion of the feature, and the code in this PR (before submitted as PR) is at https://forums.scummvm.org/viewtopic.php?f=2&t=5663
I have written this code 1 year ago, and waited for appropriate testing for Loom, as it's the most problematic game to trim, since it's really using the extra 40 pixels. The time has passed, and I decided to send this PR, without Loom.
The other games besides Loom are much safer - Zak uses the extra space for inventory, and it's handled in this PR. The other games don't use it at well.
This also closes https://bugs.scummvm.org/ticket/11290