Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCUMM: FM-TOWNS: Add optional trimming to 200 pixels height #2913

Merged
merged 1 commit into from Apr 20, 2021

Conversation

@ZvikaZ
Copy link
Contributor

@ZvikaZ ZvikaZ commented Apr 4, 2021

Trimming the screen to 200 pixels allows using aspect ratio correction.

Aspect ratio correction for FM-TOWNS has been requested for long time.
A discussion of the feature, and the code in this PR (before submitted as PR) is at https://forums.scummvm.org/viewtopic.php?f=2&t=5663

I have written this code 1 year ago, and waited for appropriate testing for Loom, as it's the most problematic game to trim, since it's really using the extra 40 pixels. The time has passed, and I decided to send this PR, without Loom.

The other games besides Loom are much safer - Zak uses the extra space for inventory, and it's handled in this PR. The other games don't use it at well.

This also closes https://bugs.scummvm.org/ticket/11290

Trimming the screen to 200 pixels allows using aspect ratio correction.
@sev-
Copy link
Member

@sev- sev- commented Apr 20, 2021

Thank you, this is a long-requested feature. Your implementation is clean and proper. Merging.

@sev- sev- merged commit a1f440c into scummvm:master Apr 20, 2021
3 checks passed
3 checks passed
Codacy Static Code Analysis Codacy Static Code Analysis
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deepcode-ci-bot Well done, no issues found!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants