Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRIM: Add hebrew fan translation detection entry #2916

Merged
merged 1 commit into from Apr 5, 2021
Merged

Conversation

@BLooperZ
Copy link
Contributor

@BLooperZ BLooperZ commented Apr 5, 2021

Following #2880
This adds detection entry for hebrew fan translation

Also, fixes off-by-1 error for the string reversal

Thanks

engines/grim/textobject.cpp Outdated Show resolved Hide resolved
@deepcode-ci-bot
Copy link

@deepcode-ci-bot deepcode-ci-bot bot commented Apr 5, 2021

Congratulations 🎉. DeepCode analyzed your code in 0.257 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@BLooperZ BLooperZ force-pushed the BLooperZ:grim_he branch from e645655 to 53dbff5 Apr 5, 2021
engines/grim/detection.cpp Outdated Show resolved Hide resolved
@BLooperZ BLooperZ force-pushed the BLooperZ:grim_he branch from 53dbff5 to 36faff9 Apr 5, 2021
@orgads
orgads approved these changes Apr 5, 2021
@BLooperZ
Copy link
Contributor Author

@BLooperZ BLooperZ commented Apr 5, 2021

Replaced the custom line reversal for visual hebrew with unicode-bidi

@BLooperZ BLooperZ force-pushed the BLooperZ:grim_he branch from 810a95f to d89e61c Apr 5, 2021
@BLooperZ
Copy link
Contributor Author

@BLooperZ BLooperZ commented Apr 5, 2021

As requested by @orgads
the changes regarding BiDi support have moved to separate PR: #2917

@orgads
Copy link
Contributor

@orgads orgads commented Apr 5, 2021

Thanks.

@orgads orgads merged commit 77a166a into scummvm:master Apr 5, 2021
3 checks passed
3 checks passed
Codacy Static Code Analysis Codacy Static Code Analysis
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deepcode-ci-bot Well done, no issues found!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants