Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRIM: improve RTL support for Hebrew fan translation #2917

Merged
merged 1 commit into from Apr 5, 2021

Conversation

@BLooperZ
Copy link
Contributor

@BLooperZ BLooperZ commented Apr 5, 2021

This amends #2880

@orgads
Copy link
Contributor

@orgads orgads commented Apr 5, 2021

Can you squash the commits?

@BLooperZ BLooperZ force-pushed the BLooperZ:grim_he_bidi branch from d69f01b to dc9202f Apr 5, 2021
@BLooperZ
Copy link
Contributor Author

@BLooperZ BLooperZ commented Apr 5, 2021

squashed

@orgads orgads self-requested a review Apr 5, 2021
engines/grim/textobject.cpp Show resolved Hide resolved
@orgads
orgads approved these changes Apr 5, 2021
@orgads
Copy link
Contributor

@orgads orgads commented Apr 5, 2021

Thank you. Merging.

@orgads orgads merged commit bc19f81 into scummvm:master Apr 5, 2021
3 checks passed
3 checks passed
Codacy Static Code Analysis Codacy Static Code Analysis
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deepcode-ci-bot Well done, no issues found!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants