Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMAGE: Gif decoder using libgif #2923

Merged
merged 2 commits into from Apr 10, 2021
Merged

Conversation

@mgerhardy
Copy link
Contributor

@mgerhardy mgerhardy commented Apr 6, 2021

This adds an external dependency to libgif - but also supports palettes for gifs. Overall it might have more features than what stb_image is offering right now.

Also see the stb_image PR: #2911 (Obviously only one should get merged)

  • Added configure support for libgif
  • Extended create_project to add libgif support
  • Verified functionality in TwinE
  • Added unittest for loading a small 2x2 gif buffer
  • Updated github actions and travis packages
  • Add libgif to buildbot after merging

This already adds full support for the floppy disk fla_gif.hqr version of Little Big Adventure 1

@mgerhardy mgerhardy mentioned this pull request Apr 6, 2021
1 of 1 task complete
@mgerhardy mgerhardy changed the title WIP: IMAGE: added git decoder using libgif WIP: IMAGE: Gif decoder using libgif Apr 6, 2021
@mgerhardy mgerhardy force-pushed the mgerhardy:pr/libgif-loader branch 2 times, most recently from e705bab to d5883d0 Apr 6, 2021
@mgerhardy mgerhardy changed the title WIP: IMAGE: Gif decoder using libgif IMAGE: Gif decoder using libgif Apr 6, 2021
@mgerhardy mgerhardy force-pushed the mgerhardy:pr/libgif-loader branch 4 times, most recently from d7dd5ad to c5e954c Apr 8, 2021
test/image/gif.h Outdated Show resolved Hide resolved
@mgerhardy mgerhardy force-pushed the mgerhardy:pr/libgif-loader branch from c5e954c to ef75d67 Apr 8, 2021
@lephilousophe
Copy link
Member

@lephilousophe lephilousophe commented Apr 10, 2021

Buildbot is ready. Merging now.

@lephilousophe lephilousophe merged commit d1aa5ae into scummvm:master Apr 10, 2021
2 of 3 checks passed
2 of 3 checks passed
Codacy Static Code Analysis Codacy Static Code Analysis
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deepcode-ci-bot Well done, no issues found!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants