Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIN32: Use UTF8 instead of local codepage #2929

Open
wants to merge 1 commit into
base: master
from

Conversation

@ZvikaZ
Copy link
Contributor

@ZvikaZ ZvikaZ commented Apr 8, 2021

Third attempt to solve the same problem as #2914 and #2928

This one is quite similar to #2914 , but without using define UNICODE.

@sluicebox , at #2914 you've mentioned problems with Win98. Do you think this PR is also problematic with Win98? What's the exact problem? Doesn't Win98 support wide chars? But we already have such usage in our codebase, at backends\platform\sdl\win32\win32_wrapper.cpp - so, is it OK? Or maybe that file isn't used at Win98?

@ZvikaZ ZvikaZ force-pushed the ZvikaZ:z_hebrew_path_icecream branch from 5a4131c to 580fd96 Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant