Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RASPBERRYPI: Remove outdated build flags #2953

Closed
wants to merge 2 commits into from

Conversation

@ccawley2011
Copy link
Member

@ccawley2011 ccawley2011 commented Apr 13, 2021

This fixes detection of OpenGL ES v2 on the buildbot.

@lephilousophe
Copy link
Member

@lephilousophe lephilousophe commented Apr 13, 2021

Checking for OpenGL... yes (OpenGL ES 2)
Checking for GL Extension Wrangler (GLEW)... not needed with OpenGL ES v2

Isn't it OK?

Loading

@ccawley2011
Copy link
Member Author

@ccawley2011 ccawley2011 commented Apr 13, 2021

Checking for OpenGL... yes (OpenGL ES 2)

Checking for GL Extension Wrangler (GLEW)... not needed with OpenGL ES v2

Isn't it OK?

Only for 2D games, where OpenGL is loaded dynamically at runtime. For 3D games, where the OpenGL ES library is linked directly, it recognises that GLEW isn't needed, but the next check fails when attempting to link to the GLESv2 library.

Loading

@lephilousophe
Copy link
Member

@lephilousophe lephilousophe commented Apr 14, 2021

Ah, yes you are right.
These includes are here to use the official proprietary OpenGL stack and get hardware acceleration old RPi 1 I think.
Maybe we should tackle the problem on toolchain side?

Loading

@lephilousophe
Copy link
Member

@lephilousophe lephilousophe commented Apr 15, 2021

So, after looking at the failure and taking some time to think about it, I think it would be simpler to use

-for lib in "-lGLESv2" "-logles2"; do
+for lib in "-lGLESv2" "-logles2" "-lbrcmGLESv2"; do

I checked that the test passes by using brcmGLESv2 but I don't have any RPi to check if it works.
What do you think?

Loading

@bluegr
Copy link
Member

@bluegr bluegr commented May 27, 2021

Any news on this?

Loading

@sev-
Copy link
Member

@sev- sev- commented Nov 1, 2021

Please, update the PR and merge it.

Loading

@aquadran
Copy link
Member

@aquadran aquadran commented Nov 12, 2021

So, after looking at the failure and taking some time to think about it, I think it would be simpler to use

-for lib in "-lGLESv2" "-logles2"; do
+for lib in "-lGLESv2" "-logles2" "-lbrcmGLESv2"; do

I checked that the test passes by using brcmGLESv2 but I don't have any RPi to check if it works. What do you think?

I think it's ok. it will check lib one by one. I have old rpi 1 I could check it. But I have to install something on it, Raspbian should be enough?

Loading

@Macleykun
Copy link

@Macleykun Macleykun commented Nov 12, 2021

So, after looking at the failure and taking some time to think about it, I think it would be simpler to use

-for lib in "-lGLESv2" "-logles2"; do
+for lib in "-lGLESv2" "-logles2" "-lbrcmGLESv2"; do

I checked that the test passes by using brcmGLESv2 but I don't have any RPi to check if it works. What do you think?

I think it's ok. it will check lib one by one. I have old rpi 1 I could check it. But I have to install something on it, Raspbian should be enough?

Raspain surely should be enough :) as it’s based on Debian which many other distro’s use aswell!

Loading

@aquadran
Copy link
Member

@aquadran aquadran commented Nov 19, 2021

According what I found on web, '/opt/vc' is present on older pi Debian releases. I installed bullseye and that directory is not present.

Loading

@aquadran
Copy link
Member

@aquadran aquadran commented Nov 19, 2021

I think along outdated build flags, build bot should not have outdated Broadcom libs. not adding them to configure

Loading

@aquadran
Copy link
Member

@aquadran aquadran commented Nov 21, 2021

separated changes merged. this is obsolete now

Loading

@aquadran aquadran closed this Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants