Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tinsel: Discworld Noir: Support for opcode 217. #2988

Merged
merged 1 commit into from May 3, 2021

Conversation

@lkramer
Copy link
Contributor

@lkramer lkramer commented Apr 28, 2021

This adds support for opcode 217. I have made the assumption that it's
voiceover, and given it an enum value to reflect that. This enables
voiceover to be played in the opening movie.

@lkramer lkramer force-pushed the lkramer:tinsel_opcode_217 branch from 53db16e to d49c17d Apr 28, 2021
@lkramer
Copy link
Contributor Author

@lkramer lkramer commented Apr 28, 2021

Hi, I understand this is probably not the highest value pull request ever, but I'm trying to grok the Tinsel 3 engine, and this is a first step. Hopefully I will be able to contribute more in the future.

@dreammaster
Copy link
Member

@dreammaster dreammaster commented Apr 29, 2021

Looks good to me, thanks, except that the tinsel engine name in the commit message should be capitalized, as in "TINSEL: ". If no-one else with Noir already installed merges this (after you do the fix) within the next couple of days, I'll try and make time to install it, test, and merge.

@peterkohaut
Copy link
Contributor

@peterkohaut peterkohaut commented Apr 29, 2021

I will check either tomorrow or over the weekend as i have several things in progress in dwnoir

@peterkohaut peterkohaut self-requested a review Apr 29, 2021
This adds support for opcode 217. I have made the assumption that it's
voiceover, and given it an enum value to reflect that. This enables
voiceover to be played in the opening movie.
@lkramer lkramer force-pushed the lkramer:tinsel_opcode_217 branch from d49c17d to 2870183 Apr 30, 2021
@lkramer
Copy link
Contributor Author

@lkramer lkramer commented Apr 30, 2021

Updated the commit message.

@peterkohaut peterkohaut merged commit 3126597 into scummvm:master May 3, 2021
3 checks passed
3 checks passed
@codacy-production
Codacy Static Code Analysis Codacy Static Code Analysis
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@deepcode-ci-bot
deepcode-ci-bot Well done, no issues found!
Details
@lkramer lkramer deleted the lkramer:tinsel_opcode_217 branch May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants