Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUILD: Deduplicate install targets #2998

Merged
merged 1 commit into from May 7, 2021
Merged

Conversation

@orgads
Copy link
Contributor

@orgads orgads commented May 4, 2021

No description provided.

@orgads orgads force-pushed the orgads:dedup-install branch 2 times, most recently from 449d5c9 to b93e285 May 4, 2021
@orgads orgads changed the title Dedup install BUILD: Deduplicate install targets May 4, 2021
@deepcode-ci-bot
Copy link

@deepcode-ci-bot deepcode-ci-bot bot commented May 4, 2021

DeepCode failed to analyze this pull request

Something went wrong despite trying multiple times, sorry about that.
Please comment this pull request with "Retry DeepCode" to manually retry, or contact us so that a human can look into the issue.

@criezy
criezy approved these changes May 6, 2021
Copy link
Member

@criezy criezy left a comment

That looks good to me.

The only comment is that it feels a bit strange to create the $(DESTDIR)$(bindir) and $(DESTDIR)$(libdir)/scummvm/ directories in the install-data target. I understand it avoids duplicating those two lines in the install and install-strip targets, but the install-data target does not copy any files to those directories, and only the install and install-strip do. So to me it seems it would maybe be a bit more logical to create the directories in the install and install-strip targets.

@orgads orgads force-pushed the orgads:dedup-install branch from b93e285 to 6200339 May 7, 2021
@orgads
Copy link
Contributor Author

@orgads orgads commented May 7, 2021

Done

@orgads orgads merged commit eef5a81 into scummvm:master May 7, 2021
2 checks passed
2 checks passed
@codacy-production
Codacy Static Code Analysis Codacy Static Code Analysis
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants