Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMMON: Simplify default MetaEngine::listSaves #3047

Merged
merged 1 commit into from Jun 7, 2021
Merged

Conversation

@SupSuper
Copy link
Contributor

@SupSuper SupSuper commented Jun 5, 2021

Currently for an engine to support custom savegame formats it needs to overload both MetaEngine::listSaves and MetaEngine::querySaveMetaInfos.

This simplifies the process by just having the default listSaves call querySaveMetaInfos, since the functionality is identical.

Use querySaveMetaInfos to get save metadata
@sev-
Copy link
Member

@sev- sev- commented Jun 7, 2021

Yep, makes all sense, thank you!

@sev- sev- merged commit da2de3e into scummvm:master Jun 7, 2021
2 checks passed
2 checks passed
@codacy-production
Codacy Static Code Analysis Codacy Static Code Analysis
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants