Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AGS: Add ags_fire and ags_agi plugin stubs (AGS_Fire.dll + ags_agi.dll) #3050

Merged
merged 1 commit into from Jun 12, 2021

Conversation

@scureuil
Copy link
Contributor

@scureuil scureuil commented Jun 8, 2021

AGS_Fire: Doesn't do anything, but allows games using plasma fire effects to load
and run.

All methods return 0

A sample game using this plugin is Maniac Mansion Mania 46.

AGS_AGI: Allows games who use AGI lowres effects to load and run.

Games using scaling mode 0 will be squashed on the screen, but others
should be playable without the screen effect.

Sample working games: Gladiator Quest, The Secret of Hutton Grammar School

@scureuil scureuil force-pushed the scureuil:ags branch from b245671 to 10a079c Jun 8, 2021
@criezy
Copy link
Member

@criezy criezy commented Jun 8, 2021

Thank you. The code itself looks OK.
However:

  • commit 51d883a and 10a079c should be squashed (let us know if you need help with that).
  • the merge commit should be removed.
@scureuil scureuil force-pushed the scureuil:ags branch from 73fbb49 to a336d5f Jun 9, 2021
 * AGS_Fire: Doesn't do anything, but allows games using plasma fire
   effects to load and run.

   All methods return 0

 * AGS_AGI: Allows games who use AGI lowres effects to load and run.

   Games using scaling mode 0 will be squashed on the screen, but others
   should be playable without the screen effect.
@scureuil scureuil changed the title AGS: Add ags_fire plugin stub (AGS_Fire.dll) AGS: Add ags_fire and ags_agi plugin stubs (AGS_Fire.dll + ags_agi.dll) Jun 9, 2021
@scureuil
Copy link
Contributor Author

@scureuil scureuil commented Jun 9, 2021

Rebased + squashed commits, it should be cleaner now.

@digitall digitall requested a review from dreammaster Jun 11, 2021
@dreammaster dreammaster merged commit 8c0c91f into scummvm:master Jun 12, 2021
2 checks passed
2 checks passed
@codacy-production
Codacy Static Code Analysis Codacy Static Code Analysis
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@scureuil scureuil deleted the scureuil:ags branch Jun 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants