Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIRECTOR: add custom target detection to director #3054

Merged
merged 11 commits into from Jun 13, 2021

Conversation

@ysj1173886760
Copy link
Contributor

@ysj1173886760 ysj1173886760 commented Jun 9, 2021

trello card which describe the task https://trello.com/c/jpwJCfZA/332-add-target-name-to-custom-detection

detect custom targets like Director Dictionary.
we need to add some info to those custom targets to get the correct description and version number.

@ysj1173886760 ysj1173886760 force-pushed the ysj1173886760:director-detection branch from 3f72d1a to c844357 Jun 11, 2021
"popup", // Pop Up Computer
"alpha", // Interactive Alphabet
"technik", // Glasklar Technology Interactive
const char *directoryGlobs[] = {

This comment has been minimized.

@sev-

sev- Jun 12, 2021
Member

This is incorrect. We do not add indent with namespace


Common::strlcpy(s_fallbackFileNameBuffer, fileName.c_str(), sizeof(s_fallbackFileNameBuffer) - 1);
desc->desc.filesDescriptions[0].fileName = s_fallbackFileNameBuffer;
desc->version = atoi(version.c_str());

This comment has been minimized.

@sev-

sev- Jun 12, 2021
Member

Do you also capture this at runtime? Seems that this code was not added.

@ysj1173886760 ysj1173886760 force-pushed the ysj1173886760:director-detection branch from 81f9390 to 96d3523 Jun 13, 2021
@sev-
Copy link
Member

@sev- sev- commented Jun 13, 2021

Thank you!

@sev- sev- merged commit 37a181f into scummvm:master Jun 13, 2021
2 checks passed
2 checks passed
@codacy-production
Codacy Static Code Analysis Codacy Static Code Analysis
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants