Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOHAWK : myst : for hearing impaired : use fuzzy logic on the space ship puzzle #3056

Merged
merged 25 commits into from Jun 12, 2021

Conversation

@AspireONE-zz
Copy link
Contributor

@AspireONE-zz AspireONE-zz commented Jun 9, 2021

MOHAWK : Myst : for hearing impaired : use fuzzy logic on the space ship puzzle

This Option is for hard-of-hearing.
It makes it easier to solve the spaceship puzzle.
Normally game uses strict binary logic here.
We change it to use fuzzy logic.
We make it checkbox option. By default it is off.

SEE :

https://forums.scummvm.org/viewtopic.php?f=1&t=16299

https://bugs.scummvm.org/ticket/12601

Copy link
Member

@bluegr bluegr left a comment

Overall, looks like a good solution for this case, although the implementation is focused mostly on the spaceship puzzle. How about the rest of the puzzles that are related to sounds?

engines/mohawk/dialogs.cpp Outdated Show resolved Hide resolved
engines/mohawk/myst_stacks/myst.cpp Outdated Show resolved Hide resolved
engines/mohawk/myst_stacks/myst.cpp Outdated Show resolved Hide resolved
engines/mohawk/myst_stacks/myst.cpp Outdated Show resolved Hide resolved
engines/mohawk/myst_stacks/myst.cpp Outdated Show resolved Hide resolved
engines/mohawk/myst_stacks/myst.cpp Outdated Show resolved Hide resolved
engines/mohawk/myst_stacks/myst.cpp Outdated Show resolved Hide resolved
engines/mohawk/myst_stacks/myst.cpp Outdated Show resolved Hide resolved
engines/mohawk/myst_stacks/myst.cpp Outdated Show resolved Hide resolved
engines/mohawk/myst_stacks/myst.cpp Outdated Show resolved Hide resolved
AspireONE-zz and others added 10 commits Jun 10, 2021
Co-authored-by: Filippos Karapetis <bluegr@gmail.com>
Co-authored-by: Filippos Karapetis <bluegr@gmail.com>
Co-authored-by: Filippos Karapetis <bluegr@gmail.com>
Co-authored-by: Filippos Karapetis <bluegr@gmail.com>
Co-authored-by: Filippos Karapetis <bluegr@gmail.com>
Co-authored-by: Filippos Karapetis <bluegr@gmail.com>
Co-authored-by: Filippos Karapetis <bluegr@gmail.com>
Co-authored-by: Filippos Karapetis <bluegr@gmail.com>
Co-authored-by: Filippos Karapetis <bluegr@gmail.com>
changed spacing
@AspireONE-zz
Copy link
Contributor Author

@AspireONE-zz AspireONE-zz commented Jun 10, 2021

Overall, looks like a good solution for this case, although the implementation is focused mostly on the spaceship puzzle. How about the rest of the puzzles that are related to sounds?

I have played whole game and pretty much the space ship is the biggest stopper.

Fortress at the Mechanical Age. You can time rotation and do it by trial and error. There are only 3 positions the fortress stops.
You do it only once, once you have whole code you don't go there again. In short you can do it without sound.

The maze at Selenitic age -- you do the map. From the map you know that you keep right side most of the time. In short you can do it without sound.

Setting up the Main Antenna dishes control. You have visual, and the arrow keep flashing when you are close so you can fine tune without sound. Besides there's only 4 such dishes and of those 2 are clearly visible on the monitor. In short you can do it without sound.

The code at the door which lead to the underground maze (Selenitic Age)... that's another hard one but ... there are only 4 sounds, so it is possible to do it. Especially if you CAREFULLY study photos of the solved door code from the internet. But it could be an another candidate for fuzzy logic :) Perhaps this one I'll add in the future.

PS: When there are videos played then I read corresponding text at the
https://dni.fandom.com/wiki/Myst_(Game)/Speeches_and_Recordings
and I know what they say.

@AspireONE-zz AspireONE-zz requested a review from bluegr Jun 10, 2021
engines/mohawk/dialogs.cpp Outdated Show resolved Hide resolved
@bluegr
Copy link
Member

@bluegr bluegr commented Jun 11, 2021

Overall, nice work!

I've made one more proposal. With that change, the proposed feature will be quite clean and straightforward. Then we can merge this.

The commit descriptions do not follow our guidelines, but we can fix this by squashing them in one and amending the message

formating
@bluegr bluegr merged commit fdbfb61 into scummvm:master Jun 12, 2021
2 checks passed
2 checks passed
@codacy-production
Codacy Static Code Analysis Codacy Static Code Analysis
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bluegr
Copy link
Member

@bluegr bluegr commented Jun 12, 2021

Thanks for your work! Merged

@AspireONE-zz
Copy link
Contributor Author

@AspireONE-zz AspireONE-zz commented Jun 12, 2021

Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants