Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WINTERMUTE: Apply colorkey according to subengine version #3126

Merged
merged 1 commit into from Jul 3, 2021

Conversation

@lolbot-iichan
Copy link
Contributor

@lolbot-iichan lolbot-iichan commented Jul 3, 2021

No description provided.

@lolbot-iichan lolbot-iichan merged commit f7d54f2 into scummvm:master Jul 3, 2021
@bluegr
Copy link
Member

@bluegr bluegr commented Jul 3, 2021

Is this related to #3115?

@lolbot-iichan
Copy link
Contributor Author

@lolbot-iichan lolbot-iichan commented Jul 3, 2021

Is this related to #3115?

@bluegr Yes, those are related.
#3115 fixes https://bugs.scummvm.org/ticket/11568 for all 24 bit PNGs.
This PR fixes https://bugs.scummvm.org/ticket/11568 for all WME 1.x games and some other cases (e.g. disabling colorkey for FoxTail subengine).

There are currently no known colorkey issues with WME Lite engine known games, but to make it more close to original behaviour, #3115 is required, so that line img.getSurface()->format.aBits() == 0 would work properly for 24-bit PNGs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants